RecycledCloud
/
smartctl_exporter
mirror of https://github.com/prometheus-community/smartctl_exporter.git
6
0
Fork 0
Code Issues Packages Projects Releases 1 Wiki Activity

Merge pull request #189 from k0ste/help2 

collect-smartctl-json: shell fixes for script (#188)
This commit is contained in:
David Randall 2024-05-05 11:04:02 -04:00 committed by GitHub
parent acdf4f30c9 3a49418e45
commit bcd3a7d173
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
collect-smartctl-json.sh
View File

@ -11,6 +11,9 @@ data_dir="${script_dir}/smartctl-data"
smartctl_args="--json --info --health --attributes --tolerance=verypermissive \ smartctl_args="--json --info --health --attributes --tolerance=verypermissive \
--nocheck=standby --format=brief --log=error" --nocheck=standby --format=brief --log=error"
# Ignore this devices
smartctl_ignore_dev_regex="^(/dev/bus)"
# Determine the json query tool to use # Determine the json query tool to use
if command -v jq >/dev/null; then if command -v jq >/dev/null; then
json_tool="jq" json_tool="jq"
@ -42,7 +45,7 @@ if [[ $# -ne 0 ]]; then
devices="${1}" devices="${1}"
else else
devices="$(smartctl --scan --json | "${json_tool}" "${json_args}" \ devices="$(smartctl --scan --json | "${json_tool}" "${json_args}" \
'.devices[].name')" ".devices[].name | select(test(\"${smartctl_ignore_dev_regex}\") | not)")"
mapfile -t devices <<< "${devices[@]}" mapfile -t devices <<< "${devices[@]}"
fi fi
@ -53,9 +56,10 @@ for device in "${devices[@]}"
data="$($SUDO smartctl ${smartctl_args} ${device})" data="$($SUDO smartctl ${smartctl_args} ${device})"
type="$(echo "${data}" | "${json_tool}" "${json_args}" '.device.type')" type="$(echo "${data}" | "${json_tool}" "${json_args}" '.device.type')"
family="$(echo "${data}" | "${json_tool}" "${json_args}" \ family="$(echo "${data}" | "${json_tool}" "${json_args}" \
'select(.model_family != null) | .model_family | sub(" |/" ; "_" ; "g")')" 'select(.model_family != null) | .model_family | sub(" |/" ; "_" ; "g")
| sub("\"|\\(|\\)" ; "" ; "g")')"
model="$(echo "${data}" | "${json_tool}" "${json_args}" \ model="$(echo "${data}" | "${json_tool}" "${json_args}" \
'.model_name | sub(" |/" ; "_" ; "g")')" '.model_name | sub(" |/" ; "_" ; "g") | sub("\"|\\(|\\)" ; "" ; "g")')"
device_name="$(basename "${device}")" device_name="$(basename "${device}")"
echo -e "\tSaving to ${type}-${family:=null}-${model}-${device_name}.json" echo -e "\tSaving to ${type}-${family:=null}-${model}-${device_name}.json"
echo "${data}" > \ echo "${data}" > \