RecycledCloud/smartctl_exporter
6
0
Fork 0
mirror of https://github.com/prometheus-community/smartctl_exporter.git synced 2024-11-16 01:33:07 +01:00
Code Issues Projects Releases 1 Packages Wiki Activity

Fix exit code bit parsing

Browse source 
The previous code was parsing left-to-right, but the bits are actually
numbered right-to-left (least to most significant). Instead of
converting to strings, just use bitmasks.

Fixes https://github.com/prometheus-community/smartctl_exporter/issues/22

Signed-off-by: Eric Culp <eculperic@gmail.com>
This commit is contained in:
Eric Culp 2022-03-17 16:52:15 -06:00
parent e27581d56a
commit 6b6fd628d2
1 changed files with 9 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
readjson.go
View file

@ -100,32 +100,31 @@ func readData(device string) (gjson.Result, error) {
func resultCodeIsOk(SMARTCtlResult int64) bool { func resultCodeIsOk(SMARTCtlResult int64) bool {
result := true result := true
if SMARTCtlResult > 0 { if SMARTCtlResult > 0 {
bits := fmt.Sprintf("%08b", SMARTCtlResult) b := SMARTCtlResult
// logger.Debug("Return code: %d: %s", SMARTCtlResult, bits) if (b & 1) != 0 {
if bits[0] == '1' {
logger.Error("Command line did not parse.") logger.Error("Command line did not parse.")
result = false result = false
} }
if bits[1] == '1' { if (b & (1 << 1)) != 0 {
logger.Error("Device open failed, device did not return an IDENTIFY DEVICE structure, or device is in a low-power mode") logger.Error("Device open failed, device did not return an IDENTIFY DEVICE structure, or device is in a low-power mode")
result = false result = false
} }
if bits[2] == '1' { if (b & (1 << 2)) != 0 {
logger.Warning("Some SMART or other ATA command to the disk failed, or there was a checksum error in a SMART data structure") logger.Warning("Some SMART or other ATA command to the disk failed, or there was a checksum error in a SMART data structure")
} }
if bits[3] == '1' { if (b & (1 << 3)) != 0 {
logger.Warning("SMART status check returned 'DISK FAILING'.") logger.Warning("SMART status check returned 'DISK FAILING'.")
} }
if bits[4] == '1' { if (b & (1 << 4)) != 0 {
logger.Warning("We found prefail Attributes <= threshold.") logger.Warning("We found prefail Attributes <= threshold.")
} }
if bits[5] == '1' { if (b & (1 << 5)) != 0 {
logger.Warning("SMART status check returned 'DISK OK' but we found that some (usage or prefail) Attributes have been <= threshold at some time in the past.") logger.Warning("SMART status check returned 'DISK OK' but we found that some (usage or prefail) Attributes have been <= threshold at some time in the past.")
} }
if bits[6] == '1' { if (b & (1 << 6)) != 0 {
logger.Warning("The device error log contains records of errors.") logger.Warning("The device error log contains records of errors.")
} }
if bits[7] == '1' { if (b & (1 << 7)) != 0 {
logger.Warning("The device self-test log contains records of errors. [ATA only] Failed self-tests outdated by a newer successful extended self-test are ignored.") logger.Warning("The device self-test log contains records of errors. [ATA only] Failed self-tests outdated by a newer successful extended self-test are ignored.")
} }
} }