RecycledCloud/smartctl_exporter
6
0
Fork 0
mirror of https://github.com/prometheus-community/smartctl_exporter.git synced 2024-11-23 01:43:07 +01:00
Code Issues Projects Releases 1 Packages Wiki Activity

Accomodate a smartmontools pre-7.3 bug (#238)

Browse source 
* Accomodate a smartmontools pre-7.3 bug

https://www.smartmontools.org/changeset/5283
---------

Signed-off-by: Nathan Carlson <carl4403@umn.edu>
This commit is contained in:
nathanlcarlson 2024-11-08 02:02:29 -06:00 committed by GitHub
parent 87e9928c4e
commit 3fa5ea5a5d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
collect-smartctl-json.sh
View file

@ -54,6 +54,8 @@ for device in "${devices[@]}"
echo -n "Collecting data for '${device}'..." echo -n "Collecting data for '${device}'..."
# shellcheck disable=SC2086 # shellcheck disable=SC2086
data="$($SUDO smartctl ${smartctl_args} ${device})" data="$($SUDO smartctl ${smartctl_args} ${device})"
# Accommodate a smartmontools pre-7.3 bug
data=${data#" Pending defect count:"}
type="$(echo "${data}" | "${json_tool}" "${json_args}" '.device.type')" type="$(echo "${data}" | "${json_tool}" "${json_args}" '.device.type')"
family="$(echo "${data}" | "${json_tool}" "${json_args}" \ family="$(echo "${data}" | "${json_tool}" "${json_args}" \
'select(.model_family != null) | .model_family | sub(" |/" ; "_" ; "g") 'select(.model_family != null) | .model_family | sub(" |/" ; "_" ; "g")

4
readjson.go
View file

@ -67,7 +67,9 @@ func readSMARTctl(logger *slog.Logger, device Device) (gjson.Result, bool) {
if err != nil { if err != nil {
logger.Warn("S.M.A.R.T. output reading", "err", err, "device", device.Info_Name) logger.Warn("S.M.A.R.T. output reading", "err", err, "device", device.Info_Name)
} }
json := parseJSON(string(out)) // Accommodate a smartmontools pre-7.3 bug
cleaned_out := strings.TrimPrefix(string(out), " Pending defect count:")
json := parseJSON(cleaned_out)
rcOk := resultCodeIsOk(logger, device, json.Get("smartctl.exit_status").Int()) rcOk := resultCodeIsOk(logger, device, json.Get("smartctl.exit_status").Int())
jsonOk := jsonIsOk(logger, json) jsonOk := jsonIsOk(logger, json)
logger.Debug("Collected S.M.A.R.T. json data", "device", device.Info_Name, "duration", time.Since(start)) logger.Debug("Collected S.M.A.R.T. json data", "device", device.Info_Name, "duration", time.Since(start))